Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9699: Beta editor: Fix o not working in Vim normal mode #9700

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 11, 2024

Summary

Fixes the o command in Joplin's CodeMirror 6 Vim emulation.

o should open a new line and enter insert mode. It was failing because our CodeMirror5 version of this command tried to use codemirror.commands.vimInsertListElement, which wasn't registered for CodeMirror5Emulation.

Fixes #9699.

Testing

  1. Enable the beta editor
  2. Enable Vim emulation
  3. Click on a non-list line
  4. Press o
    • A new line should be opened after the current, the editor should be in insert mode
  5. Type something, then press Escape
  6. Click on a line in a list
  7. Press o
    • A new line should be opened and the list should be continued.
  8. Repeat steps 2-8 for the legacy CM5 editor.

This has been successfully tested on Ubuntu 23.10.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fixes #9699: Fix o not working in Vim normal mode Desktop: Fixes #9699: Beta editor: Fix o not working in Vim normal mode Jan 11, 2024
@laurent22 laurent22 merged commit fdbfa78 into laurent22:dev Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beta editor: Pressing o in vim normal mode does nothing
2 participants