amend UVIP KEP with some additional details #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavalamp
reviewed
Mar 23, 2023
keps/sig-api-machinery/3903-unknown-version-interoperability-proxy/README.md
Outdated
Show resolved
Hide resolved
lavalamp
reviewed
Mar 23, 2023
keps/sig-api-machinery/3903-unknown-version-interoperability-proxy/README.md
Outdated
Show resolved
Hide resolved
lavalamp
reviewed
Mar 23, 2023
| requests reflect the newest one. We specifically rule out merging discovery docs, because | ||
| merging discovery is: | ||
|
|
||
| * complicated |
There was a problem hiding this comment.
this part still seems wrong to me or at least needs to go in an unresolved block
lavalamp
reviewed
Mar 23, 2023
| locally (we can use the StorageVersion API), it will proxy the request to | ||
| one of the apiservers that is listed in the object. If an apiserver fails | ||
| to respond is not available, then we will return a 503 (there is a small | ||
| possibility of a race between the controller registering the apiserver |
There was a problem hiding this comment.
I'm gonna merge this but we need a better story for this race, IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.