forked from kubernetes/enhancements
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amend UVIP KEP with some additional details #20
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -149,7 +149,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release* | |
## Summary | ||
|
||
When a cluster has multiple apiservers at mixed versions (such as during an | ||
upgrade or downgrate), not every apiserver can serve every resource at every | ||
upgrade or downgrade), not every apiserver can serve every resource at every | ||
version. | ||
|
||
To fix this, we will add a filter to the handler chain in the aggregator which | ||
|
@@ -189,19 +189,34 @@ incorrectly or objects being garbage collected mistakenly. | |
|
||
## Proposal | ||
|
||
API change: | ||
* To the apiservices API, add an "alternates" clause, a list of | ||
apiservers which believe they can serve the group-version. | ||
We will use the existing `StorageVersion` API to figure out which group, versions, | ||
and resources an apiserver can serve. | ||
|
||
We will also need to make discover reports the same set of resources everywhere. We propose | ||
routing discovery requests from old-apiservers to the new api-server, so that all discovery | ||
requests reflect the newest one. We specifically rule out merging discovery docs, because | ||
merging discovery is: | ||
|
||
* complicated | ||
* represents an intermediate state which may not even make sense | ||
* the problems that merging discovery solves (i.e. preventing orphaned objects) can actually | ||
be solved by the dynamic feature flag KEP, so solving it here would be redundant and | ||
unnecessarily complex. | ||
|
||
By routing all discovery requests to the newest apiserver, we can ensure that namespace and gc | ||
controllers do what they would be doing if the upgrade happened instantaneously. | ||
|
||
|
||
API server change: | ||
* A controller adds the apiserver to the list of alternates for its built-in | ||
group-versions. | ||
* The same controller removes expired apiservers from the list. (Enabled by the | ||
apiserver identity work.) | ||
* A new handler is added to the stack: | ||
- If the request is for a group/version the apiserver doesn't have locally (we | ||
can use the StorageVersion API), it will proxy the request to one of the | ||
alternates instead. | ||
|
||
- If the request is for a group/version/resource the apiserver doesn't have | ||
locally (we can use the StorageVersion API), it will proxy the request to | ||
one of the apiservers that is listed in the object. If an apiserver fails | ||
to respond is not available, then we will return a 503 (there is a small | ||
possibility of a race between the controller registering the apiserver | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm gonna merge this but we need a better story for this race, IMO |
||
with the resources it can serve and receiving a request for a resource | ||
that is not yet available on that apiserver). | ||
|
||
### User Stories (Optional) | ||
|
||
|
@@ -257,8 +272,6 @@ TODO: security / cert stuff. | |
|
||
## Design Details | ||
|
||
TODO: specific API change(s) | ||
|
||
TODO: explanation of how the handler will determine a request is for a resource | ||
that should be proxied. | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part still seems wrong to me or at least needs to go in an unresolved block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure moved.