-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muted Words Settings Page #5934
Conversation
This comment has been minimized.
This comment has been minimized.
5a224c5
to
4d2ae13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good. A few comments. The styling looks a little off on the muted words.
4d2ae13
to
6a8fb59
Compare
|
73ff12d
to
e5cdb3c
Compare
Tried to run locally and ran into this on startup: Will blow out node modules and try again. |
I see it's up on kp.odysee.com too, nevermind! Poked Mark about the commentron side fix, he'll get it up shortly. |
Gave some feedback for Mark to fix the things you ran into also. Comments should be enabled by default, gave him a heads up about that.
Minor:
|
96d4120
to
23dd135
Compare
- Allow 'followed' and 'unfollowed' list to be overridden via props. - Allow labels to be overridden via props. - Add ability to disable "Suggestions"
## Changes: 1) TagSearch: hide the "control tags" in the Creator Settings page (irrelevant). 2) TagSearch: show the "control tags" when creating/editing Channel (let's use `setting.CommentsEnabled` instead). 3) TagSearch: show the "control tags" when creating/editing Content (`disable-comments` can be used to block comments at the per-claim level, e.g. allow comments in general but block only for specific claims). ## Missing pieces: For (2) and (3), some work is needed to hide the comment GUI when `setting.CommentsEnabled` is disabled for a particular channel. That flag is not ready in Commentron yet, so I'm not sure how this will be done at the moment. In other words, the checkbox does nothing at the moment. ## Potential flaw: This change will hide all control tags. If we have more tags in the future and would like to selectively disable some, we'll have to change this parameter to an array instead. Since the usage is not widespread at the moment, a single `disableControlFlag` seems cleaner (don't over-think it yet).
23dd135
to
c2e72e9
Compare
@tzarebczan, this is ready for final review before shipping Muted Words. Nothing new to test other than to look for corner-cases, I think. Changes/fixes:
Merging Request
|
Demo
KP dev instance.
Issue
Closes #5833 Support creator controlled commenting settings (mainly muted word list for now)
I believe only "Muted Words" is functional at this moment, as noted by the issue's title.
The rest, while set-able, has no effect, so we'll need to comment out the "General" and "Tip" cards before merging later.
Notes to reviewer
fetchCommentsApi: Relay error messages to the client's 'catch' block.
commit. This would fail if any clients are depending onres.results
on the failure case, but I don't think there are any.GUI
The comment contains contents that are blocked by %author%
when commenting with a blocked word.#5931 Fast actions will often be undone when there's a background update
by waiting for a 1s user-idle before syncing the GUI with the API data.API bugs
[""]
instead of[]
, causing the matching to always be true.unable to marshall
error when changing any numerical setting.