Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muted Words Settings Page #5934

Merged
merged 9 commits into from
May 26, 2021
Merged

Muted Words Settings Page #5934

merged 9 commits into from
May 26, 2021

Commits on May 25, 2021

  1. Fix lint

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7108878 View commit details
    Browse the repository at this point in the history

  2. TagsSearch: tweaks to allow re-use beyond tags 

    - Allow 'followed' and 'unfollowed' list to be overridden via props.
- Allow labels to be overridden via props.
- Add ability to disable "Suggestions"
    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a0448a2 View commit details
    Browse the repository at this point in the history

  3. fetchCommentsApi: Relay error messages to the client's 'catch' block.

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    929fb82 View commit details
    Browse the repository at this point in the history

  4. Commentron Settings API

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c26c49a View commit details
    Browse the repository at this point in the history

  5. Add/implement SettingsCreatorPage

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f6ffc4f View commit details
    Browse the repository at this point in the history

  6. Relay and beautify 'blocked words' error message

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    bbea138 View commit details
    Browse the repository at this point in the history

  7. Hide "control tags" except when creating/editing claims. 

    ## Changes:
1) TagSearch: hide the "control tags" in the Creator Settings page (irrelevant).
2) TagSearch: show the "control tags" when creating/editing Channel (let's use `setting.CommentsEnabled` instead).
3) TagSearch: show the "control tags" when creating/editing Content (`disable-comments` can be used to block comments at the per-claim level, e.g. allow comments in general but block only for specific claims).

## Missing pieces:
For (2) and (3), some work is needed to hide the comment GUI when `setting.CommentsEnabled` is disabled for a particular channel. That flag is not ready in Commentron yet, so I'm not sure how this will be done at the moment. In other words, the checkbox does nothing at the moment.

## Potential flaw:
This change will hide all control tags. If we have more tags in the future and would like to selectively disable some, we'll have to change this parameter to an array instead. Since the usage is not widespread at the moment, a single `disableControlFlag` seems cleaner (don't over-think it yet).
    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    088ef71 View commit details
    Browse the repository at this point in the history

  8. Hide Creator Settings that are not ready

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fb36c70 View commit details
    Browse the repository at this point in the history

  9. Creator Settings now require a minimum staked LBC.

    @infinite-persistence
    infinite-persistence committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c2e72e9 View commit details
    Browse the repository at this point in the history