Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed possibility to configure dialog size and even dialog itself. #22

Closed
slavap opened this issue Jul 30, 2020 · 3 comments
Closed

Needed possibility to configure dialog size and even dialog itself. #22

slavap opened this issue Jul 30, 2020 · 3 comments

Comments

@slavap
Copy link

slavap commented Jul 30, 2020

Currently there is a property: menuConstraints, but it is ignored in case of dialogBox = true
As result on large screens dialog takes almost all available space, which looks bad.
Please add property dialogConstraints to be able to limit dialog size.
Also it would be absolutely perfect if option for overriding showDialog() call is added, like:

OnShowDialog onShowDialog;

typedef OnShowDialog  = Future Function(BuildContext context, Widget menuWidget);

That way it will be possible to configure showDialog() exactly the way it is needed for my application, even replacing standard dialog to custom one.

@slavap slavap changed the title Needed possibility to configure dialog size. Needed possibility to configure dialog size and even dialog itself. Jul 30, 2020
@lcuis
Copy link
Owner

lcuis commented Jul 31, 2020

Hello @slavap ,
Is this an improvement proposal to add dialogConstraints or to add onShowDialog? Or does one solve the other?

@slavap
Copy link
Author

slavap commented Jul 31, 2020

@lcuis better to add onShowDialog, it will be more powerful customization. But nothing wrong with adding both, for simple cases dialogConstraints could be easier to use.

lcuis added a commit that referenced this issue Mar 7, 2021
@lcuis
Copy link
Owner

lcuis commented Mar 7, 2021

Sorry for the late reply.

I hope version 2.0.2 solves this issue as well as #23 with the possibility to control the layout of the dropdown dialog through buildDropDownDialog function as shown in example app.

If it doesn't solve, please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants