Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin and padding override for menu/dialog content #23

Closed
slavap opened this issue Jul 30, 2020 · 3 comments
Closed

Margin and padding override for menu/dialog content #23

slavap opened this issue Jul 30, 2020 · 3 comments

Comments

@slavap
Copy link

slavap commented Jul 30, 2020

Currently it is hardcoded:

child: Card(
        color: widget.menuBackgroundColor,
        margin: EdgeInsets.symmetric(
            vertical: widget.dialogBox ? 10 : 5,
            horizontal: widget.dialogBox ? 10 : 4),
        child: Container(
          constraints: widget.menuConstraints,
          padding: EdgeInsets.symmetric(vertical: 15, horizontal: 15),
          child: Column(
            mainAxisAlignment: MainAxisAlignment.start,
            crossAxisAlignment: CrossAxisAlignment.start,
            mainAxisSize: MainAxisSize.min,
            children: <Widget>[
              titleBar(),
              searchBar(),
              list(),
              closeButtonWrapper(),
            ],
          ),
        ),
      ),

Need properties: menuMargin and menuPadding to be able to override these hardcoded values.

image

@lcuis
Copy link
Owner

lcuis commented Jul 30, 2020

Hi @slavap ,

It seems to me that your suggestion is quite similar to #18 .
Also, wouldn't this solve the main request of #22 ?

@slavap
Copy link
Author

slavap commented Jul 30, 2020

@lcuis #22 is about ability to override showDialog(), but dialog content will be passed already constructed as input parameter. And if margin/padding are already hardcoded in constructed content you cannot change them in override.

lcuis added a commit that referenced this issue Mar 7, 2021
@lcuis
Copy link
Owner

lcuis commented Mar 7, 2021

Sorry for the late reply.

I hope version 2.0.2 solves this issue as well as #22 with the possibility to control the layout of the dropdown dialog through buildDropDownDialog function as shown in example app.

If it doesn't solve, please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants