Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rework stacking flow, closes #335 #359

Merged
merged 10 commits into from
Dec 2, 2020
Merged

fix: rework stacking flow, closes #335 #359

merged 10 commits into from
Dec 2, 2020

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Nov 18, 2020 •
edited by github-actions bot
Loading

@kyranjamie kyranjamie linked an issue Nov 18, 2020 that may be closed by this pull request
Send user back to home screen directly with clear activity upon initiation of Stacking #335
Closed
@kyranjamie kyranjamie force-pushed the fix/stacking-flow branch 3 times, most recently from 529a059 to da8bbe8 Compare November 18, 2020 10:30
@kyranjamie kyranjamie linked an issue Nov 18, 2020 that may be closed by this pull request
Ensure duration values line up for Stacking #340
Closed
@kyranjamie kyranjamie force-pushed the fix/stacking-flow branch 8 times, most recently from da2310a to ca7de60 Compare November 23, 2020 14:54
@markmhendrickson
Copy link
Collaborator

Partial Stacking works well for me:

image

Only small confusing thing is seeing slightly less STX locked than I entered (85k), presumably because it was less fees. But that'll get addressed with #279.

This was linked to issues Nov 24, 2020
Add ability to initiate Stacking with partial holdings #295
Closed
Add comma delimitation for numerical values #342
Closed
hstove
hstove approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work as always

app/pages/stacking/step/choose-amount.tsx Outdated Show resolved Hide resolved
app/pages/stacking/step/choose-amount.tsx Show resolved Hide resolved
app/pages/stacking/step/choose-amount.tsx Show resolved Hide resolved
app/utils/form/validate-decimals.ts Show resolved Hide resolved
app/utils/stacking/pox.spec.ts Outdated Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the fix/stacking-flow branch 2 times, most recently from 8086dbb to 6381ad8 Compare November 30, 2020 10:15
@kyranjamie kyranjamie linked an issue Dec 1, 2020 that may be closed by this pull request
Hide Stacking "get started" as soon as Stacking transaction is pending #344
Closed
@kyranjamie kyranjamie mentioned this pull request Dec 1, 2020
Closed
@kyranjamie
Copy link
Collaborator Author

kyranjamie commented Dec 2, 2020 •
edited
Loading

I'm going to merge this in, @timstackblock — you can test form release/stacking

edit: I'm working on integrating kens stacking client, so would recommended holding off on this

@kyranjamie kyranjamie merged commit 7157802 into release/stacking Dec 2, 2020
@kyranjamie kyranjamie deleted the fix/stacking-flow branch December 2, 2020 10:33
@blockstack-devops
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments
@blockstack-devops
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstove hstove hstove approved these changes

@markmhendrickson markmhendrickson markmhendrickson approved these changes

@aulneau aulneau Awaiting requested review from aulneau

@zone117x zone117x Awaiting requested review from zone117x

Assignees

@timstackblock timstackblock

Labels
released
Projects
None yet
Milestone
No milestone
5 participants
@kyranjamie @markmhendrickson @blockstack-devops @hstove @timstackblock