Fix legit select path find #984
Conversation
src/ext/legit/peek-legit.lisp
Outdated
| (format nil "~a~a" | ||
| (lem-core/commands/project:find-root (buffer-filename)) | ||
| file))))) |
There was a problem hiding this comment.
Using merge-pathnames seems to be a good idea.
| @@ -320,7 +320,13 @@ Notes: | |||
| (define-command peek-legit-select () () | |||
| (alexandria:when-let ((file (get-matched-file))) | |||
| (quit) | |||
| (alexandria:when-let ((buffer (find-file-buffer file))) | |||
| (alexandria:when-let | |||
| ((buffer (or (and (uiop:file-exists-p file) | |||
There was a problem hiding this comment.
(I don't really know the context for this fix)
In legit, pressing Enter in the legit window calls this function to visit the file at point. There was a file listing, the file should exist. So if the file doesn't exist anymore, we maybe should display a message to the user (instead of doing nothing)? (and refresh the legit window?)
Also I thought the %filename slot of a buffer had the full path, not requiring to get the project root?
exple:
[ ] %FILENAME = "/home/vince/lisp-projects/lem/legit.lisp"
There was a problem hiding this comment.
I'm not sure, but seems like the path is indeed not correct:
2023-08-22.13-14-35.mp4
Maybe the buffer doesn't have the information about the absolute path? 🤔
There was a problem hiding this comment.
I can't reproduce. Do you try to visit an unstaged file?
- start from directory mode
- move cursor on an "unstaged changes" line
- press Enter
? this works for me, I visit the file at point. I can stage it with "s" too.
|
What is the state of this? |
I myself can't reproduce, I have yet to try more, and I have an open improvement suggestion in my comment:
|
|
I added a message when the file cannot be found 👍 |
src/ext/legit/peek-legit.lisp
Outdated
| ((buffer (or (and (uiop:file-exists-p file) | ||
| (find-file-buffer file)) | ||
| (find-file-buffer | ||
| (merge-pathnames | ||
| (lem-core/commands/project:find-root (buffer-filename)) | ||
| file))))) | ||
| (switch-to-buffer buffer)))) | ||
| (switch-to-buffer buffer) | ||
| (message "File ~a doesn't exist." file)))) |
There was a problem hiding this comment.
Elsewhere, we use editor-error to display errors.
Is it possible to do that here as well?
|
Thank you! |
No description provided.