Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legit select path find #984

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fix legit select path find #984

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba4a16d
Fix legit select path find
Sasanidas Aug 21, 2023
21da5f7
Use merge-pathnames
Sasanidas Aug 22, 2023
ca9663c
Add message to inform the user
Sasanidas Sep 3, 2023
5a518a9
Use editor-error instead of message
Sasanidas Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/ext/legit/peek-legit.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,13 @@ Notes:
(define-command peek-legit-select () ()
(alexandria:when-let ((file (get-matched-file)))
(quit)
(alexandria:when-let ((buffer (find-file-buffer file)))
(alexandria:when-let
((buffer (or (and (uiop:file-exists-p file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't really know the context for this fix)

In legit, pressing Enter in the legit window calls this function to visit the file at point. There was a file listing, the file should exist. So if the file doesn't exist anymore, we maybe should display a message to the user (instead of doing nothing)? (and refresh the legit window?)

Also I thought the %filename slot of a buffer had the full path, not requiring to get the project root?

exple:

[ ]  %FILENAME       = "/home/vince/lisp-projects/lem/legit.lisp"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but seems like the path is indeed not correct:

2023-08-22.13-14-35.mp4

Maybe the buffer doesn't have the information about the absolute path? 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce. Do you try to visit an unstaged file?

  • start from directory mode
  • move cursor on an "unstaged changes" line
  • press Enter

? this works for me, I visit the file at point. I can stage it with "s" too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did just that 🤔

(find-file-buffer file))
(find-file-buffer
(format nil "~a~a"
(lem-core/commands/project:find-root (buffer-filename))
file)))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using merge-pathnames seems to be a good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 👍

(switch-to-buffer buffer))))

(define-command peek-legit-next () ()
Expand Down