Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subjectLimit option usage and validation #114

Merged
merged 2 commits into from
May 9, 2020
Merged

subjectLimit option usage and validation #114

merged 2 commits into from
May 9, 2020

Conversation

storageddd
Copy link
Contributor

Current changes solve next problems:

  1. subjectLimit property overrides by defaultMaxLineWidth.
  2. Subject message validates by subjectLimit property, but when it trims, include prefix and scope – trim does not correct.

@storageddd
Copy link
Contributor Author

@leonardoanalista, can you review changes?

@leonardoanalista leonardoanalista merged commit 1174700 into leoforfree:master May 9, 2020
@leonardoanalista
Copy link
Member

thanks for the PR! 👏 👏 👏

@storageddd
Copy link
Contributor Author

@leonardoanalista, can you update version of the package? It can't be used in other projects. Because last version tagged as 6.2.0 and it version doesn't includes this updates. Thanks!

@leonardoanalista
Copy link
Member

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

YvonneYu pushed a commit to thefirstweb/cz-customizable that referenced this pull request Nov 6, 2020
* 'master' of github.com:leoforfree/cz-customizable:
  fix: package url inside package.json after org creation (leoforfree#130)
  fix: update lodash security version
  feat: standalone version as global bin (leoforfree#129)
  build(deps): bump js-yaml from 3.12.2 to 3.13.1 (leoforfree#92)
  fix: support prepared commit message (leoforfree#122)
  build(deps): bump handlebars from 4.1.2 to 4.5.3 (leoforfree#110)
  docs: mention possible alternative path for config (leoforfree#123)
  subjectLimit option usage and validation (leoforfree#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants