fix: support prepared commit message #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used as a git hook, using git commit -m'my message' was not making use of 'my message'. Now it does.
politician
changed the title
|
@leonardoanalista Build is passing on my fork Thank you |
|
it look like Travis it stuck.. I'l have a loo today ok? |
leonardoanalista
approved these changes
Jul 7, 2020
|
@Incorrupt release! |
|
Cool thank you! |
YvonneYu
pushed a commit
to thefirstweb/cz-customizable
that referenced
this pull request
Nov 6, 2020
* 'master' of github.com:leoforfree/cz-customizable: fix: package url inside package.json after org creation (leoforfree#130) fix: update lodash security version feat: standalone version as global bin (leoforfree#129) build(deps): bump js-yaml from 3.12.2 to 3.13.1 (leoforfree#92) fix: support prepared commit message (leoforfree#122) build(deps): bump handlebars from 4.1.2 to 4.5.3 (leoforfree#110) docs: mention possible alternative path for config (leoforfree#123) subjectLimit option usage and validation (leoforfree#114)
|
This is not a fix, it looks more like a new feature to me. And it breaks the habit to just press The parsing of the commit message body does not take into account the format of the commit message, the same commit message that has been generated by this tool on the previous commit. It includes into the suggested commit body the line |
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of http://leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#196, re leoforfree/cz-customizable#196
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#173, re leoforfree/cz-customizable#196
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#173, re leoforfree/cz-customizable#196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two kind of people:
git commitgit commit -mcz-customizable is for those who
git commitWith this PR, cz-customizable is now for everybody!
When used as a git hook, using
git commit -m'my message'was not making use of'my message'. Now it does.This PR adds support for
subjectquestionsubjectquestion and the other lines are passed as the default answer for thebodyquestionIt is non invasive as it is passed as a
defaultto enquirer. So the user can just press enter to use it or type another message if he wishes to.