Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.9.2] Running VNC test without hardware acceleration #902

Closed
uncleDecart opened this issue Oct 10, 2023 · 6 comments
Closed

[0.9.2] Running VNC test without hardware acceleration #902

uncleDecart opened this issue Oct 10, 2023 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@uncleDecart
Copy link
Collaborator

Eden version: 0.9.2

Here we have not based on an OCI image error. This indicates that we try to run VNC test (with qcow2 image inside) on the EVE-OS without hardware acceleration, which is not expected

@uncleDecart uncleDecart added bug Something isn't working help wanted Extra attention is needed labels Oct 10, 2023
@giggsoff
Copy link
Collaborator

As I can see here we start EVE-OS without HW-assisted virtualization support. In that case previously we start the test only in case of gcp or large options. With novel test separation I see two options (I am voting for the second option):

  1. Remove the line
  2. Insert the line for example from here (three lines above and the script in the bottom of file) into the vnc test

@uncleDecart
Copy link
Collaborator Author

@giggsoff It's weird, because now we are using buildjet to run our workflows, and they support nested virtualization, so I believe they should support HW-accelerated virtualization. Could it be that we need to tinker our hw-assisted virtualization support?

@giggsoff
Copy link
Collaborator

Good to know. If so, please adjust the line. But we MUST make it conditional for buildjet runners (we can try to check kvm support on-fly or rely on some variable with runner name).

@uncleDecart
Copy link
Collaborator Author

I believe on-fly check is more robust (it's a about a capability of a machine, not different behaviour for different runners) maybe it makes sense to dynamically determine this value for default config based on machine it's running when running ./eden config add default? that would assume being cautious when transferring files on a different system though

@giggsoff
Copy link
Collaborator

I am voting for less logic inside eden config add default. Better to keep constants there, if it is possible, to not try to predict tests behaviour based on combination of conditions. And running EVE-OS without acceleration is not good idea, but what we are forced to use.
I hope that somethink like kvm-ok will give us needed information.

@giggsoff
Copy link
Collaborator

As we decided to use buildjet (accelerated) runners conditionally we still need to adjust the test to avoid running in case of non-accelerated runs. So seems we still need the second option from here #902 (comment).

uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 3, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 6, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 7, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 7, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 8, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 8, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 8, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart added a commit to uncleDecart/eden that referenced this issue Nov 9, 2023
This closes lf-edge#902

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants