-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new workflows #909
Switch to new workflows #909
Conversation
5d22b03
to
394f61c
Compare
I did not test it yet in my fork and would be great if @yash-zededa can check workflow files as well |
.github/workflows/test.yml
Outdated
steps: | ||
- id: fork-check | ||
run: | | ||
if ["${{ github.event.repository.full_name}}" == "lf-edge/eve" || "${{ github.event.repository.full_name}}" == "lf-edge/eden"]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to extend this check down to action/setup-environment
and enable eve.accel
if workflow is running on buildjet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we could actually change setup-environment and use some utilities to determine if hw acceleration is possible, that way we don't have coupling with runner, but rather with capability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this: https://manpages.ubuntu.com/manpages/impish/man1/kvm-ok.1.html ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also found option with lscpu :), sending it rn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
39f3909
to
75bd362
Compare
.github/workflows/eden.yml
Outdated
${{ github.workspace }}/adam.log | ||
test_suite_pr: | ||
if: github.event.review.state == 'approved' | ||
uses: ./eden/.github/workflows/test.yml@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we split the PR into two if you would like to modify the file you point onto here, but it doesn't exists in master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file exists in master, only change here is runners for forks will be ubuntu :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I cannot understand, why we point onto branch here. I want to test my changes in eden with the workflow. But what we will check in that case? Main branch or my changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax is GHA is tricky, my intention was to use local action, fixed to use just that. GHA seems to work, I'll wait for it to finish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like another problem. It is really tricky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just my poor bash-ninja skills :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably
[[ "${{ github.event.repository.full_name }}" == "lf-edge/eve" ]] || [[ "${{ github.event.repository.full_name }}" == "lf-edge/eden" ]]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With spaces around braces ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'll make sense to include similar thing to eden_setup to speed up process in eden repository
75bd362
to
80c3c31
Compare
Something weird is happening with GHA I see error which I shouldn't see here will retry in some time |
d488b5a
to
07c3f93
Compare
25f3184
to
258ca47
Compare
onborading seems to fail. Checked locally with master, works |
I can see Update: Can we check something like: |
I think you're right @giggsoff, let me check your changes |
0653840
to
7795d2b
Compare
Trying to make it work https://media.giphy.com/media/OVwfSuQXVUUI8/giphy.gif |
Now it's working, but we need to check if it works with EVE |
I think that we can merge it, try to run manually with eve_image on master branch and if it doesn't work, we do more fixes before, releasing eden and switching on EVE. Any objections @giggsoff @yash-zededa ? |
So it gets curiouser and curiouser. I found this Let's try to checkout to 3.5.3 |
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
a87dee5
to
f708402
Compare
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
f708402
to
50eac3a
Compare
@@ -34,7 +34,7 @@ runs: | |||
- name: Install Packages | |||
run: | | |||
sudo add-apt-repository ppa:stefanberger/swtpm-jammy | |||
sudo apt install -y qemu-utils qemu-system-x86 jq swtpm | |||
sudo apt install -y qemu-utils qemu-system-x86 jq swtpm lscpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems lscpu
comes from util-linux
package.
50eac3a
to
ef2c49f
Compare
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
ef2c49f
to
d51627c
Compare
Following on #910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check #909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Please rebase on top of master with #924 merged |
d51627c
to
8a3abbd
Compare
Well, I can see host cpu in EVE-OS start line. So we use acceleration. Let's wait for the rest of the test. But seems we should workaround cloud-init test (revert changes or stabilize and adjust EVE-OS hash). |
Following work done to split eden test workflows in lf-edge#863 and integration of this workflows in EVE repository, this commit switches to use new workflows in eden itself Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
New workflows are running on Buildjet runners, however, they are not available in personal forks and it is useful to run test.yml in fork, that is why this commit introduces determine-runner job, which checks if we are in fork and changes runner to ubuntu-2204 which is available everywhere Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
This closes lf-edge#902 Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
8a3abbd
to
f4bbf15
Compare
New day, new problems: I can see The self-hosted runner lost communication with the server again and again https://github.com/lf-edge/eden/actions/runs/6811998752?pr=909 |
I'll ask BuildJet about it |
@giggsoff buildjet did not respond, but I see that workflows are running, any objections to merge it? |
Following on lf-edge#910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check lf-edge#909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Following on #910 we saw that EVE checks out Eden master code and not code from tag from yml file and if master fails tests are failing on EVE, which is undesirable https://github.com/lf-edge/eve/actions/runs/6613253197/job/17960730583?pr=3516#step:2:474 Investigating it more turns out in version 3.5.3 of github checkout action behaviour is what we need. Check #909 for more info Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Following work done to split eden test workflows in #863 and integration
of this workflows in EVE repository, this commit switches to use new
workflows in eden itself
Also, new workflows are running on Buildjet runners, however, they
are not available in personal forks and it is useful to run test.yml
in fork, that is why this commit introduces determine-runner job,
which checks if we are in fork and changes runner to ubuntu-2204 which
is available everywhere