EVE Discovery service: move allow_to_discover to AppInst port
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleDecart
requested review from
gkodali-zededa and
eriknordmark
and removed request for
eriknordmark
|
I see yetus error But I marked field 24 as reserved, not sure we should leave it there |
proto/config/netconfig.proto
Outdated
| @@ -55,6 +55,10 @@ message NetworkAdapter { | |||
| // valid vlan id range: 2 - 4093 | |||
| // vlan id 1 is implicitly used by linux bridges | |||
| uint32 access_vlan_id = 41; | |||
|
|
|||
| // allow AppInstance to discover other AppInstances | |||
| // attached to its network instances. default is false | |||
There was a problem hiding this comment.
Shouldn't this say "to this network instance" in singular?
Or to the network instance attached to this adapter?
There was a problem hiding this comment.
renamed to "this network instance"
eriknordmark
approved these changes
Apr 16, 2024
This is more granular approach. From appInstance perspective, you also know which network port will be used. Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
fix-discovery
branch
from
b9724ca to
d46864c
Compare
milan-zededa
approved these changes
Apr 17, 2024
uncleDecart
added a commit
to uncleDecart/eve-api
that referenced
this pull request
Apr 22, 2024
PR lf-edge#46 accidently added allow_to_discover field to app_instance which was removed in lf-edge#52 Not deprecating field number 25 (allow_to_discover) because we haven't had released EVE with this API yet, so we don't have to do this Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more granular approach. From appInstance perspective,
you also know which network port will be used.