Fix allow to discover #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR lf-edge#46 accidently added allow_to_discover field to app_instance which was removed in lf-edge#52 Not deprecating field number 25 (allow_to_discover) because we haven't had released EVE with this API yet, so we don't have to do this Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
| @@ -210,10 +208,6 @@ message AppInstanceConfig { | |||
| // PatchEnvelopeRef is used to track all patch envelopes used by the app instance | |||
| PatchEnvelopeRef patchRef = 23; | |||
|
|
|||
| // allow AppInstance to discover other AppInstances | |||
There was a problem hiding this comment.
But this was already removed in #52 based on the diffs, right?
There was a problem hiding this comment.
Ah - presumably due to some mismerge. Got it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #46 accidently added allow_to_discover field to app_instance
which was removed in #52
Not deprecating field number 25 (allow_to_discover) because we haven't
had released EVE with this API yet, so we don't have to do this