hal::soft::bit_bang_i2c does not configure output pins to open drain
#36
Assignees
Labels
bug
Something isn't working
Comments
kammce
added a commit
that referenced
this issue
Aug 17, 2024
Critical bug fix in bit_bang_i2c that can lead to device damage. The output pins NEED to be set as open drain in order to not cause bus contention which can damage devices and cause short circuits. The constructor now properly configures the sda and scl output pins and configures and performs initial configuration. Resolves #36
kammce
added a commit
that referenced
this issue
Aug 18, 2024
Critical bug fix in bit_bang_i2c that can lead to device damage. The output pins NEED to be set as open drain in order to not cause bus contention which can damage devices and cause short circuits. The constructor now properly configures the sda and scl output pins and configures and performs initial configuration. Resolves #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The bit bang i2c driver does not configure the output pins to open drain relying on the developer to configure the pins themselves before its use. The driver should ensure that the hardware is initialized into a safe configuration before returning. This was an oversight in my review of the #7 PR.
The text was updated successfully, but these errors were encountered: