🚑 Fix initialization in bit_bang_i2c constructor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Critical bug fix in bit_bang_i2c that can lead to device damage. The output pins NEED to be set as open drain in order to not cause bus contention which can damage devices and cause short circuits. The constructor now properly configures the sda and scl output pins and configures and performs initial configuration. Resolves #36
kammce
force-pushed
the
fix-bit-bang-i2c
branch
from
20a2d03
to
d65bb5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical bug fix in bit_bang_i2c that can lead to device damage. The output pins NEED to be set as open drain in order to not cause bus contention which can damage devices and cause short circuits.
The constructor now properly configures the sda and scl output pins and configures and performs initial configuration.
Resolves #36