Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kaddht content routing doc #192

Closed
wants to merge 9 commits into from
Closed

feat: kaddht content routing doc #192

wants to merge 9 commits into from

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Sep 16, 2022 •
edited
Loading

Context

  • Adds initial Kademlia content routing piece

    Some of this content may be a bit IPFS-specific, feedback would be great on this too

  • resolves Create Content Routing doc #23

Latest preview

Please view the latest Fleek preview here.

@salmad3 salmad3 marked this pull request as draft September 16, 2022 09:24
@salmad3 salmad3 added ready for review PR is ready for review and removed in progress labels Sep 19, 2022
@salmad3 salmad3 marked this pull request as ready for review September 19, 2022 09:37
@salmad3
Copy link
Member Author

salmad3 commented Oct 4, 2022

Wondering who the best person would be to review this? @p-shahi @mxinden

@p-shahi
Copy link
Member

p-shahi commented Oct 15, 2022

@guseggert can you help review this?

guseggert
guseggert reviewed Oct 19, 2022
View reviewed changes
Copy link

@guseggert guseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got halfway through, will followup later with more comments!

content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
content/concepts/content-routing.md Outdated Show resolved Hide resolved
salmad3 and others added 2 commits October 19, 2022 12:02
@salmad3 salmad3 requested review from guseggert and removed request for mxinden October 22, 2022 17:23
@salmad3 salmad3 changed the title Add KadDHT content routing add/kaddht-content-routing-doc Nov 11, 2022
@p-shahi
Copy link
Member

p-shahi commented Nov 18, 2022

@guseggert any chance you can take a look at this when you have time?

@salmad3 salmad3 changed the title add/kaddht-content-routing-doc add: kaddht content routing doc Nov 22, 2022
@salmad3 salmad3 mentioned this pull request Nov 23, 2022
Open
2 tasks
@salmad3 salmad3 changed the title add: kaddht content routing doc feat: kaddht content routing doc Dec 5, 2022
This was referenced Jan 15, 2023
Merged
Closed
@salmad3 salmad3 removed the ready for review PR is ready for review label Jan 15, 2023
@salmad3
Copy link
Member Author

salmad3 commented Jan 15, 2023

Closing based on the latest [linked] PRs that incorporate this material as part of the new content routing section and the new docs theme.

@salmad3 salmad3 closed this Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert Awaiting requested review from guseggert

Assignees
No one assigned
Labels
None yet
Projects
go-libp2p
Archived in project
libp2p Product
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Content Routing doc
3 participants
@salmad3 @p-shahi @guseggert