Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kad-dht content routing #293

Closed
wants to merge 2 commits into from
Closed

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Jan 15, 2023

Context

Latest preview

@salmad3 salmad3 marked this pull request as draft January 15, 2023 17:06
@salmad3 salmad3 changed the title feat: kaddht content routing feat: kad-dht content routing Jan 16, 2023
@salmad3 salmad3 marked this pull request as ready for review January 17, 2023 10:38
@salmad3 salmad3 added the ready for review PR is ready for review label Jan 17, 2023
@salmad3 salmad3 added the P1 High label Jan 26, 2023
@p-shahi
Copy link
Member

p-shahi commented Feb 23, 2023

@Jorropo would you be able to help review this doc?

@p-shahi p-shahi removed P1 High ready for review PR is ready for review labels Feb 23, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not merging this pull request. In my eyes this document describes one use-case of the libp2p Kademlia DHT, namely its usage within IPFS. Examples:

  • Pinning content
  • Provider records to locate data (note that the provider record holders don't hold the data, but only the provider record)
  • Garbage collection at the 90% mark.
  • CIDs

@p-shahi fine with closing here?

@p-shahi
Copy link
Member

p-shahi commented Feb 24, 2023

That sounds good to me @mxinden I think we can close this, add to the IPFS docs if appropriate and then link to that document instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants