Bootstrap immediately after calls to BootstrapWithConfig

[bigs]

closes #163. need to test locally just to be sure.

[Stebalien]

So, OnSignal is useful when you already have a channel but, in this case, I'd just fire off your own goroutine:

dht.Process().Go(func(p goprocess.Process) {
    for {
       select {
       ...
       case <-p.Closing():
           return
       }
    }
})

[bigs]

ah, totally!

[bigs]

@Stebalien that change is up!

[Stebalien]

I need to stop forgetting about half-written reviews...

It should be possible to just write something like:

for {
  select {
  case <-time.After(cfg.Period):
    <-p.Go(dht.bootstrapWorker(cfg)).Closed()
  case <-p.Closing():
    return
  }
}

goprocess will tell the worker when to quit. Does that sound right?

[bigs]

@Stebalien so the details behind the slightly more complex logic are: the implementation of goprocess ticker functions is such that the process will not be executed again if the previous instantiation of it has not terminated, effectively skipping one of our intervals. i sought to keep that behavior consistent, though if it's not particularly necessary for us i'm happy to remove it! in c++ i'd probably just handle this with an std::atomic<bool> flag and be done with it, but the chan chan thing seemed to be most idiomatically go.

[Stebalien]

Hm. That's kind of an odd way to do it... The code above will just avoid starting the timer until the previous operation has finished (i.e., it will cause the system to sleep interval between operations).

[Stebalien]

I'd just go with the simple code. I'm not aware of any good reason we do what we do with ticker.

[bigs]

done!

[Stebalien]

This'll need a <-p.Go(dht.bootstrapWorker(cfg)).Closed() at the top (to actually fix the bug 😄). Sorry about that.

[bigs]

hahahaha wasn't even thinking about that. yup.

[bigs]

smh hahaha. done