Add AddAddresses method to DHT #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
added a commit
that referenced
this pull request
Sep 7, 2023
* WIP * revise protobuf * remove gogo protobuf dependency * WIP * add kadt package * Add routing test * add custom zikade dependency * Import zikade code * Remove generics from zikade imported code * Update to latest go-kademlia * Cleanup naming of events * Minor naming cleanup * Change maintainers for v2 while being developed * remove Zikade dependency * Consolidate type parameters * Change config test structure * use opentelemetry * use convenience attribute methods * let coord package use tele * fix golint warnings * use clock.Clock * add telemetry context tests * Improve telemetry documentation * fix test race * fix garbage collection race * Add AddAddresses method to DHT (#879) * Add AddAddresses method to DHT * Add AddAddresses method to DHT * go mod tidy * Rename Query Skip errors * go fmt coordinator.go * Fix test flakes * Fix lint errors --------- Co-authored-by: Ian Davis <18375+iand@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this to better understand how to test the DHT+coordinator together. Some things need to be refined as we haven't really thought about how things like routing update notifications should be exposed to users of the DHT (or even if they should be).
Added a Close method to the coordinator and the DHT calls it from its own Close method.
Added some test helper methods but there is overlap between some of the existing ones. We should work out a nice set of test helpers that can set up configurations of DHTs. I'd like to do something similar to the Topology test helper that the coordinator package uses but the current Topology implementation doesn't rely on libp2p which avoids some timing issues (like waiting for peerstore etc)