This repository has been archived by the owner on May 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- likewise for writeInsecureMsg
@yusefnapora – would be amazing to have Go benchmarks for the handshake and the cypher. Then we can measure the impact of these changes very quickly in terms of memory, CPU and allocs. |
You can use |
closing, since much of this is irrelevant in light of #53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a largish refactor that (AFAICT) doesn't change anything semantically, but removes a lot of duplicate code and tricky control flow, and generally makes the code easier to follow and reason about.
The main changes are:
xx
andik
packages into acore
packagecore/common.go
rw.go
readLength
+insecure.Read
intoreadMsgInsecure
(same forwriteMsgInsecure
)Encrypt
/Decrypt
methods on theNoiseSession
type, and removedcrypto.go
HandshakeCodec
interface to bundle up the variousEncode
/Decode
functions and the methods that alterNoiseSession
state when preparing / accepting handshake messages.NoiseSession
with a codec when we initialize it, and moves the encoding / decoding logic from the handshake runners to theNoiseSession
runHanshake
methodsXXfallback
path into separate functions fromXX
pathThere are still a few things I'd like to clean up, but I think this is a good start.
closes #42