This repository has been archived by the owner on May 26, 2022. It is now read-only.
Remove Noise Pipes & IK handshake
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Mar 2, 2020
| hs.e = *e | ||
| } | ||
|
|
||
| hs.e = GenerateKeypair() |
There was a problem hiding this comment.
comment for future improvement: generating the keypair here is weird. But we can fix that in a followup patch.
|
I'm inclined to merge this, merge any refactors, then do a full code review rather than reviewing the changes. At the moment, I believe there are a bunch of changes we'd like to make and reviewing code we know we're going to change probably isn't the best use of our time. |
|
@Stebalien sounds good to me. I'll merge this and do a refactor / cleanup pass, then come grab you to review as a whole before we decide to tag a release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in libp2p/specs#249, we've decided to remove Noise pipes from the spec, and only support
XXin the initial version.The code is much cleaner as a result. At some point I'll probably break up the giant
runHandshakemethod, but I decided to leave it alone for now so this PR doesn't creep in scope too much.cc @raulk @Stebalien @jacobheun @mpetrunic