Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicHost.NewStream doesn't resolve DNS addresses #1302

Closed
Stebalien opened this issue Jan 19, 2022 · 0 comments · Fixed by #1342
Closed

BasicHost.NewStream doesn't resolve DNS addresses #1302

Stebalien opened this issue Jan 19, 2022 · 0 comments · Fixed by #1342

Comments

@Stebalien
Copy link
Member

While BasicHost.Connect will resolve DNS addresses, BasicHost.NewStream will try to establish a connection if one doesn't already exist, but it won't try to resolve DNS addresses.

The real issue here is that network.NewStream tries to automatically connect to a peer, but has no way to find/resolve addresses for that peer.
gammazero added a commit that referenced this issue Feb 22, 2022
@gammazero
Resolve addresses when creating a new stream
1718bca 
BasicHost.NewStream will try to establish a connection if one doesn't already exist.  This will fail if the hosts addresses have not yet been resolved.  This PR resolves the hosts addresses before creating the stream and possible new connection.

Fixes #1302
@gammazero gammazero mentioned this issue Feb 22, 2022
Merged
marten-seemann pushed a commit that referenced this issue Mar 31, 2022
@gammazero
Resolve addresses when creating a new stream (#1342)
e8d3df9 
* Resolve addresses when creating a new stream

BasicHost.NewStream will try to establish a connection if one doesn't already exist.  This will fail if the hosts addresses have not yet been resolved.  This PR resolves the hosts addresses before creating the stream and possible new connection.

Fixes #1302

* Changes from review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve addresses when creating a new stream libp2p/go-libp2p
1 participant
@Stebalien