Resolve addresses when creating a new stream #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasicHost.NewStream will try to establish a connection if one doesn't already exist. This will fail if the hosts addresses have not yet been resolved. This PR resolves the hosts addresses before creating the stream and possible new connection. Fixes #1302
Stebalien
requested changes
Feb 28, 2022
There was a problem hiding this comment.
This will make a DNS request every time even if we already have a connection. Take a look at the code in RoutedHost.NewStream, we should do the same thing.
We should probably also change the implementation in RoutedHost to set "nodial" so we don't try to dial twice (well, three times...)
Stebalien
approved these changes
Mar 15, 2022
gammazero
added a commit
to ipni/storetheindex
that referenced
this pull request
Jan 18, 2023
This code is not needed as the problem was fixed by this PR: libp2p/go-libp2p#1342
gammazero
added a commit
to ipni/storetheindex
that referenced
this pull request
Jan 18, 2023
* Remove code to resolve address before gostream.Dial This code is not needed as the problem was fixed by this PR: libp2p/go-libp2p#1342 * No longer necessary to explicitly close resource manager It is not necessary to explicitly close a libp2p host's resource manager. The problem was fixed in this PR: libp2p/go-libp2p#1343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BasicHost.NewStream will try to establish a connection if one doesn't already exist. This will fail if the destination host's addresses have not yet been resolved. This PR resolves the destination host's addresses before creating the stream and possible new connection.
Fixes #1302