perf/basic_host: Don't handle address change if we hasn't anyone #1115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic_host.background
is used for handling address changed events, but thenode
may be created withlibp2p.NoListenerAddrs
.the
h.updateLocalIpAddr
is cost a little CPU time.But I use
NoListenerAddrs
with many (one thousand) tiny test nodes, and all these test nodes communicate with other peers by a full feature node (by pubsub or relay) in the same process.The basic_host.background would use many CPU time and add 1000 useless goroutine in this situatuion.
I'm not sure whether the
network
could dolisten
afterhost.background
started.So I just keep the background goroutine and skip one round if there hasn't any listener address.