add options for disabling the default listen address/transports #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
added
kind/bug
Stebalien
commented
Aug 16, 2018
options.go
Outdated
| // | ||
| // This will both clear any configured listen addrs and prevent libp2p from | ||
| // applying the default listen address option. | ||
| var NoListen = func(cfg *Config) error { |
So, in go-ipfs at least, we *don't* pass the listen addresses into the libp2p constructor. Instead, we specify them later. This option allows us to tell libp2p to not listen by default.
Stebalien
force-pushed
the
feat/no-default-listen
branch
from
4115983
to
a36d383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, in go-ipfs at least, we don't pass the listen addresses into the libp2p constructor. Instead, we specify them later.
This option allows us to tell libp2p to not listen by default.
The alternative is to just revert that PR and tell users that they need to configure libp2p to listen on some port. The question is really: "what's more surprising?"