Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move go-libp2p-discovery to p2p/discovery/generic #1280

Closed
wants to merge 56 commits into from
Closed

move go-libp2p-discovery to p2p/discovery/generic #1280

wants to merge 56 commits into from

Conversation

marten-seemann
Copy link
Contributor

I'm not really happy with the name generic here, but it's the best I can come up with.
We already have a p2p/discovery folder (which contains mdns). @Stebalien, any ideas for a better name?

vyzo and others added 30 commits October 12, 2018 14:32
@vyzo
interface and utility functions
729ccf7
@vyzo
discovery implementation using ContentRouting
6f35407
@vyzo
niceties and best practices
18d33e6
@vyzo
test and gx package update
78e044b
@vyzo
document the use of SHA256 as the cid hash function
529d255
@vyzo
use 6hrs as ttl for routing based advertisements
78be55e
@vyzo
Merge pull request #8 from libp2p/fix/ttl
28991ad 
use 6hrs as ttl for routing based advertisements
@vyzo
correctly encode ns to CID
d79d2b3
@vyzo
Merge pull request #11 from libp2p/fix/issue-10
74c1088 
correctly encode ns to CID
@vyzo
add a timeout to Provide in routing.Advertise
ad52aea
@raulk
clarify comment.
431fb82
@vyzo
Merge pull request #12 from libp2p/fix/provide-timeout
f87fdaa 
add a timeout to Provide in routing.Advertise
@raulk
remove Jenkinsfile.
f2dbbfc
@vyzo
use 3hrs as routing advertisement ttl
ff747ff
@Stebalien
Merge pull request #23 from libp2p/fix/routing-advertisement-period
2914cd6 
Use 3hrs as routing advertisement ttl
@vyzo
allow user-spceified TTL in routing advertisements
6b503a0
@vyzo
add options to utility interface
8780de3
@vyzo
fix test
548f847
@vyzo
Merge pull request #25 from libp2p/feat/options
740aa16 
More consistent use of options
@raulk
Consolidate abstractions and core types into go-libp2p-core (#24)
9ecee91
@aschmahmann
added initial backoff cache discovery
4af0294
@aschmahmann
added discovery based content routing
321bb64
@aschmahmann
added discovery options to discovery based content routing
7b39072
@aschmahmann
refactored backoffcache and increased an internal channel size.
aab2fe9
@aschmahmann
refactor constructor functions for BackoffFactory implementations. re…
6b0ce1b 
…factored BackoffDiscovery to better differentiate the BackoffStrategy from BackoffFactory.
@aschmahmann
polynomialbackoff: added checks for small degree polynomials
4e95d0b
@aschmahmann
add backoff connector
8b246a3
@aschmahmann
Merge branch 'feat/backoff' of github.com:libp2p/go-libp2p-discovery …
feebad9 
…into feat/backoff
@aschmahmann
fix and tests for backoff connector
786613c
@aschmahmann
added configurable channel buffer sizes to the backoff cache.
82c6465
aschmahmann and others added 22 commits October 29, 2019 10:51
@aschmahmann
cleanup some function signatures
9e6f484
@aschmahmann
cleanup backoffcache event dispatching logic
646b138
@aschmahmann
more documentation and function argument coalescing
da0575a
@Stebalien
Merge pull request #26 from libp2p/feat/backoff
5b180a2 
Add Backoff Cache Discovery
@aschmahmann
add tests for backoff factory reuse
7637c9d
@aschmahmann
backoff strategy factory constructors take random seeds instead of ra…
b6d7176 
…ndom sources
@aschmahmann
backoff strategy factory constructors take sources instead of seeds f…
f700a5d 
…or randomness
@Stebalien
Merge pull request #54 from libp2p/fix/53
d24d24c 
Fix race with reuse of randomness
@edwargix
Put period at end of sentence
76b48d8
@vyzo
Merge pull request #65 from edwargix/master
4cfb5d8 
Put period at end of sentence
@iand
Fix hang in BackoffDiscovery.FindPeers when requesting limit lower th…
ce31d03 
…an number of peers available
@marten-seemann
fix staticcheck
1814268
@marten-seemann
Merge pull request #70 from libp2p/fix-staticcheck
91366aa 
fix staticcheck
@marten-seemann
Merge pull request #69 from iand/issue-67
b9be440 
Fix hang in BackoffDiscovery.FindPeers when requesting limit lower than number of peers available
@marten-seemann
remove deprecated types
5a98da6
@Stebalien
Merge pull request #73 from libp2p/remove-deprecated-types
e7ee122 
remove deprecated types
@guseggert
feat: plumb peerstore contexts changes through (#75)
d8eeb78
@marten-seemann
chore: update go-log to v2
706f740
@marten-seemann
fix flaky TestBackoffDiscoveryMultipleBackoff test on CI (#80)
f93a41d
@marten-seemann
remove dependency on the go-libp2p-peerstore/addr package (#82)
8d17b35
@marten-seemann
Merge remote-tracking branch 'p2p/discovery/generic/master' into merg…
b53ee87 
…e-discovery
@marten-seemann
fix import paths
d2ad848
@marten-seemann marten-seemann mentioned this pull request Jan 3, 2022
Closed
69 tasks
@Stebalien
Copy link
Member

Maybe just make them individual packages? I.e.:

  1. backoff (backoff.go, backoffcache.go, backoffconnector.go)
  2. routing (routing.go)
  3. util (util.go). Maybe put backoff under util?

Mocks could either go in the routing package, or in a new "mocks" package.

@marten-seemann marten-seemann mentioned this pull request Jan 9, 2022
Merged
@marten-seemann marten-seemann deleted the merge-discovery branch April 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marten-seemann @Stebalien @vyzo @raulk @aschmahmann @edwargix @iand @guseggert