-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move go-libp2p-discovery here #1291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use 6hrs as ttl for routing based advertisements
correctly encode ns to CID
add a timeout to Provide in routing.Advertise
Use 3hrs as routing advertisement ttl
More consistent use of options
More consistent use of options
…factored BackoffDiscovery to better differentiate the BackoffStrategy from BackoffFactory.
…into feat/backoff
Put period at end of sentence
…an number of peers available
fix staticcheck
Fix hang in BackoffDiscovery.FindPeers when requesting limit lower than number of peers available
remove deprecated types
remove deprecated types
marten-seemann
force-pushed
the
discovery
branch
2 times, most recently
from
January 16, 2022 11:31
6c757e3
to
f8f1710
Compare
marten-seemann
force-pushed
the
discovery
branch
from
January 16, 2022 11:32
f8f1710
to
4269c5f
Compare
vyzo
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1280.
This implements the naming suggested by @Stebalien in #1280 (comment).