feat: integrate gossipsub by default #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2019
|
In general, it looks good to me. But, shouldn't we want to test with multiple topics with multiple publishers and subscribers as well? This is usually the case when differences in implementations appear. |
|
@Mikerah ideally yes! I will work on adding some more tests |
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
6 times, most recently
from
6ea3f0c to
660d2e4
Compare
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
660d2e4 to
92d2f65
Compare
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
92d2f65 to
20e8cf3
Compare
jacobheun
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modified the pubsub tests, to test both implementations with gossipsub and floodsub implementations.
Needs: