-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate gossipsub by default #19
Conversation
0af82b9
to
ebbeee6
Compare
There are some unrelated failures in CI. This should be gtg once deps are updated. |
eb94b69
to
eeb0f98
Compare
eeb0f98
to
18b46df
Compare
@vasco-santos fyi, I rebased with master to get the latest test fixes here. |
Thanks @jacobheun |
18b46df
to
998fd42
Compare
998fd42
to
46d0c18
Compare
6f728e5
to
8acc4bd
Compare
@jacobheun updated this with the newest release candidate of I could remove the pubsub wrapper for promises, which was great. However, I had to do minor changes to |
@vasco-santos if that is breaking the sub class we need to fix js-libp2p. If other users are extending the libp2p class that's going to be a huge pain for them. |
I was thinking about it earlier. I don't know how common it is to extend the libp2p class and override The easier solution I see now is to change all the following functions: |
@vasco-santos I think libp2p/js-libp2p#394 should resolve the problem. |
Thanks, I will try that here! But seems to fix the issue |
It worked 🎉 |
🎉just working on 1 last PR for libp2p and then I'll do another RC release |
8acc4bd
to
b257a2a
Compare
v0.26.0-rc.2 is on the web |
b257a2a
to
710c192
Compare
Updated here! Thanks @jacobheun |
fix: promisified methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to the latest release of libp2p, this is gtg!
This PR modified the configuration of a libp2p node, in order to allow the selection of the pubsub implementation to use.
Also, Gossipsub was added as the default pubsub implementation.
Needs:
gossipsub-js