feat: add support for specifying noise and secio #32
Conversation
feat: add ability to specify local daemons test: run connect tests with multiple configs
jacobheun
force-pushed
the
feat/crypto-noise
branch
from
c77458b
to
83ae5d4
Compare
|
There is an issue with noise interop right now. js to go hangs, and go to js receives the following error: I tested this by installing the WIP go-libp2p-daemon branch and updating to the latest version of the noise repo |
| @@ -131,6 +131,9 @@ class Daemon { | |||
| } | |||
|
|
|||
| const daemon = execa(this._binPath, execOptions) | |||
| if (process.env.DEBUG) { | |||
| daemon.stderr.pipe(process.stderr) | |||
There was a problem hiding this comment.
Aren't library logs suppose to be in process.stdout?
Might be useful to pass custom env to execa, I think something like execa(this._binPath, execOptions, {env: {DEBUG: "libp2p:noise, libp2p:secio"}}) should be supported
There was a problem hiding this comment.
All debug logs are going to stderr as we're just using the defaults in the debug module atm.
execa forwards env to the new process, so it shouldn't be necessary as we only need forwarding right now. We don't need the conditional though.
|
FYI, with the latest changes in master, I created #40 to replace this PR considering that with would be easier than rebasing this PR. |
|
Closing in favor of #40 |
Depends on libp2p/go-libp2p-daemon#158
Depends on libp2p/js-libp2p-daemon#32
The connect tests can now be run with different configurations to make it easier to run those suites for both secio and noise. It doesn't currently support the ability to test fallback strategies (ie: using secio when the other node doesn't know noise).
Using Local Daemons
I've added the ability to specify local daemons when running the tests to make verifying go daemon changes easier. Doing this is noted in the readme.
TODO