chore: deprecate old peer store api #598

vasco-santos · 2020-04-01T09:08:12Z

This PR is a follow up of #590 on the context of the PeerStore improvements described on #582

It removes the older peerStore API and adds a temporary record of peer id's. This is needed because the dht needs the peerStore to keep track of peers' public key. Once we have the key book, it will be removed.

Needs:

libp2p/js-libp2p#590 (needs rebase when this merged)
libp2p/js-libp2p-kad-dht#179

Unblocks:

libp2p/js-libp2p-daemon#38
libp2p/interop#36 (also uses this here to get the tests green)

BREAKING CHANGE: the peer-store api changed. Check the API docs for the new specification.

vasco-santos · 2020-04-10T11:37:32Z

This should be ready to review @jacobheun !

FYI. the interop tests are failing here, but I can run them locally with any problems. Not exactly sure yet about the issue, but I think you can start reviewing this, as well as the dht PR.

They depend on from one another, so I would say that we should probably make a beta release in the dht

BREAKING CHANGE: the peer-store api changed. Check the API docs for the new specification.

jacobheun

A few minor things, otherwise this is looking good.

src/peer-store/address-book.js

jacobheun · 2020-04-15T14:33:35Z

src/peer-store/address-book.js

@@ -183,6 +185,12 @@ class AddressBook extends Book {
    return multiaddrInfos
  }

+  _setPeerId (peerId) {


Add this to the base Book class?

src/peer-store/index.js

jacobheun · 2020-04-15T14:36:37Z

src/peer-store/proto-book.js

@@ -132,6 +134,12 @@ class ProtoBook extends Book {

    return this
  }
+
+  _setPeerId (peerId) {


Same as above, add to Book class.

jacobheun · 2020-04-15T14:42:10Z

test/peer-store/proto-book.spec.js

@@ -96,7 +95,7 @@ describe('protoBook', () => {
      const supportedProtocols = ['protocol1', 'protocol2']

      let changeCounter = 0
-      ee.on('change:protocols', () => {
+      peerStore.on('change:protocols', () => {


I think we should add the events to the API docs at https://github.com/libp2p/js-libp2p/blob/0.28.x/doc/API.md#events. We could split that into subsections (libp2p, libp2p.peerStore) to link to from the TOC. WDYT?

Yes, that makes sense. Good call

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

vasco-santos · 2020-04-16T09:11:16Z

Addressed you review, the only tests failing are related to the delegated routing issue that is being fixed.

I also made a pre release for the dht, we just need to figure out how we should merge this, with the interop dependency that needs the daemon updated.

jacobheun · 2020-04-16T10:52:31Z

doc/API.md

@@ -41,6 +41,8 @@
  * [`metrics.forPeer`](#metricsforpeer)
  * [`metrics.forProtocol`](#metricsforprotocol)
 * [Events](#events)
+  * [`libp2p`](#eventslibp2p)
+  * [`libp2p.peerStore`](#eventslibp2ppeerStore)


Both of these anchor links won't work, they shouldn't be prefaced with events

doc/API.md

jacobheun · 2020-04-16T11:19:09Z

I also made a pre release for the dht, we just need to figure out how we should merge this, with the interop dependency that needs the daemon updated.

We could leave it as a branch for now. The other option could be to cherry pick out the daemon specification updates in libp2p/interop#32. That would enable us to do a pre release of the daemon and just install it and use it in the interop tests here on CI.

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

jacobheun

LGTM

* chore: deprecate old peer-store api BREAKING CHANGE: the peer-store api changed. Check the API docs for the new specification. * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com> * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com> Co-authored-by: Jacob Heun <jacobheun@gmail.com>

vasco-santos mentioned this pull request Apr 1, 2020

chore: use new peer store api libp2p/js-libp2p-kad-dht#179

Merged

2 tasks

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch 2 times, most recently from 904226b to 98004ad Compare April 1, 2020 12:51

This was referenced Apr 1, 2020

chore: update peer store api and libp2p api without peer-info libp2p/js-libp2p-daemon#38

Merged

chore: update libp2p daemon with peer-store libp2p/interop#36

Merged

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch 3 times, most recently from 61563bb to d2b9960 Compare April 2, 2020 18:20

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch 2 times, most recently from c9b3248 to fb66739 Compare April 9, 2020 19:41

vasco-santos changed the base branch from master to 0.28.x April 10, 2020 08:26

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch 2 times, most recently from af6454f to a2098bd Compare April 10, 2020 09:21

vasco-santos marked this pull request as ready for review April 10, 2020 09:51

vasco-santos requested a review from jacobheun April 10, 2020 11:36

vasco-santos mentioned this pull request Apr 11, 2020

chore: use new content and peer routing apis libp2p/js-libp2p-kad-dht#181

Merged

4 tasks

vasco-santos force-pushed the 0.28.x branch from c99a7a2 to be45fc4 Compare April 14, 2020 11:20

chore: deprecate old peer-store api

060d69a

BREAKING CHANGE: the peer-store api changed. Check the API docs for the new specification.

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch from 56b70f9 to 060d69a Compare April 15, 2020 14:19

jacobheun suggested changes Apr 15, 2020

View reviewed changes

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch from d805aba to 7248b4c Compare April 16, 2020 08:33

vasco-santos mentioned this pull request Apr 16, 2020

chore: rewrite peer-store submit and retrieve docs #605

Merged

chore: apply suggestions from code review

655dd74

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch from 7248b4c to 655dd74 Compare April 16, 2020 09:08

jacobheun reviewed Apr 16, 2020

View reviewed changes

chore: apply suggestions from code review

dbc6210

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>

vasco-santos force-pushed the chore/deprecate-old-peer-store-api branch from 712a69b to dbc6210 Compare April 16, 2020 13:01

jacobheun approved these changes Apr 16, 2020

View reviewed changes

jacobheun merged commit 54212cb into 0.28.x Apr 16, 2020

jacobheun deleted the chore/deprecate-old-peer-store-api branch April 16, 2020 13:20

vasco-santos mentioned this pull request Apr 27, 2020

feat: peerstore persistence #619

Merged

2 tasks

vasco-santos mentioned this pull request May 4, 2020

feat: keybook #626

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deprecate old peer store api #598

chore: deprecate old peer store api #598

vasco-santos commented Apr 1, 2020 •

edited

Loading

vasco-santos commented Apr 10, 2020

jacobheun left a comment

jacobheun Apr 15, 2020

jacobheun Apr 15, 2020

jacobheun Apr 15, 2020

vasco-santos Apr 16, 2020

vasco-santos commented Apr 16, 2020

jacobheun Apr 16, 2020

jacobheun commented Apr 16, 2020

jacobheun left a comment

chore: deprecate old peer store api #598

chore: deprecate old peer store api #598

Conversation

vasco-santos commented Apr 1, 2020 • edited Loading

vasco-santos commented Apr 10, 2020

jacobheun left a comment

Choose a reason for hiding this comment

jacobheun Apr 15, 2020

Choose a reason for hiding this comment

jacobheun Apr 15, 2020

Choose a reason for hiding this comment

jacobheun Apr 15, 2020

Choose a reason for hiding this comment

vasco-santos Apr 16, 2020

Choose a reason for hiding this comment

vasco-santos commented Apr 16, 2020

jacobheun Apr 16, 2020

Choose a reason for hiding this comment

jacobheun commented Apr 16, 2020

jacobheun left a comment

Choose a reason for hiding this comment

vasco-santos commented Apr 1, 2020 •

edited

Loading