This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: add acceptIncomingConnection to ConnectionManager #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to check we can accept an incoming connection before exchanging PeerIds, add a method to the ConnectionManager interface that can be called by the upgrader.
1 task
mpetrunic
reviewed
Oct 4, 2022
mpetrunic
approved these changes
Oct 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [@libp2p/interface-connection-manager-v1.2.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-connection-manager-v1.1.1...@libp2p/interface-connection-manager-v1.2.0) (2022-10-04) ### Features * add acceptIncomingConnection to ConnectionManager ([#295](#295)) ([5d460e8](5d460e8))
|
🎉 This PR is included in version @libp2p/interface-connection-manager-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [@libp2p/interface-mocks-v5.1.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v5.0.0...@libp2p/interface-mocks-v5.1.0) (2022-10-04) ### Features * add acceptIncomingConnection to ConnectionManager ([#295](#295)) ([5d460e8](5d460e8))
|
🎉 This PR is included in version @libp2p/interface-mocks-v5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
So does this break js-libp2p until libp2p/js-libp2p#1398 is merged? My trivial change is breaking CI: libp2p/js-libp2p#1398 |
libp2p/js-libp2p#1404 is merged as temporary fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to check we can accept an incoming connection before exchanging PeerIds, add a method to the ConnectionManager interface that can be called by the upgrader.