This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Stability fixes and spdy upgrade #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update deps chore: remove test on pre-push chore: remove non jenkins ci files chore: fix aegir test commands chore: fix linting fix: make callback optional fix: improve stability
ghost
assigned chore: restrict files for npm publishing License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
approved these changes
Nov 9, 2018
| }) | ||
| }) | ||
|
|
||
| // This logic can be removed once spdy-transport doesn't emit empty errors |
There was a problem hiding this comment.
Should we add a todo here to have the linter to track this for future removal?
There was a problem hiding this comment.
Yes, good call. I will add a todo in there when I update the stream muxer dep.
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the stability of the spdy transport. This has also been tested against the libp2p test suite. You can check those tests in libp2p/js-libp2p#271, where this branch is temporarily being used.
.endnow supports callback being optionalfilesto package.json to ensure no unwanted files are published to npmDependes on libp2p/interface-stream-muxer#50