Update examples #271
Merged
Update examples #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
force-pushed
the
docs/examples
branch
from
b862c11 to
8ee8cbe
Compare
|
@vasco-santos this is ready to review. |
vasco-santos
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
@jacobheun LGTM
Left just a minor suggestion for you to consider.
Co-Authored-By: jacobheun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with the examples running on the latest branch of master.
There's currently an issue with the muxing example, 3.js. It's throwing
Error: incorrect header check at Zlib.zlibOnError [as onerror] (zlib.js:153:17)when the second node connects. I'm looking into the issue.Required by #249