Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

test: add transport compliance tests #149

Closed
wants to merge 3 commits into from

Conversation

maschad
Copy link
Member

@maschad maschad commented May 2, 2023

@maschad maschad changed the title test: add transport compliance tests (#132) test: add transport compliance tests May 2, 2023
@p-shahi
Copy link
Member

p-shahi commented May 9, 2023

This is unblocked now right?

@dhuseby
Copy link

dhuseby commented Jun 1, 2023

is this a flakey test that needs investigating still?

@maschad
Copy link
Member Author

maschad commented Jun 1, 2023

is this a flakey test that needs investigating still?

No @dhuseby , actually there is some refactoring work that is being done on the compliance tests in order to land this. @achingbrain can expound

@BigLep
Copy link

BigLep commented Jun 3, 2023

No @dhuseby , actually there is some refactoring work that is being done on the compliance tests in order to land this.

Is there a tracking issue for this work that is blocking this? I'm asking so know where to follow along.

@dhuseby
Copy link

dhuseby commented Jun 8, 2023

I want to echo @BigLep 's request. @achingbrain is there a tracking issue for what's blocking this PR?

@p-shahi
Copy link
Member

p-shahi commented Jun 8, 2023

We discussed this in the js-libp2p maintainers call on 2023-06-06, this is parked until some tech debt related to compliance test refactoring is landed. Issue for that created here: libp2p/js-libp2p#1852
As of 2023-06-06 that refactoring work hasn't been pushed as a draft to GitHub.
This branch doesn't have a whole lot going on it and though it's a draft, it's getting some traffic. Therefore, I'll close this until libp2p/js-libp2p#1852 is resolved

@p-shahi p-shahi closed this Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libp2p(@webrtc): Add transport compliance tests
5 participants