Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libp2p(@webrtc): Add transport compliance tests #1836

Open
achingbrain opened this issue Apr 20, 2023 · 2 comments
Open

libp2p(@webrtc): Add transport compliance tests #1836

achingbrain opened this issue Apr 20, 2023 · 2 comments

Comments

@achingbrain
Copy link
Member

Now that this transport can listen for incoming connections (e.g. browser to browser), it should be able run the interface transport compliance test suite.

This will ensure it implements the interface in a way consistent with other transports.
@maschad
Copy link
Member

maschad commented Apr 20, 2023

Are you planning on taking this on @achingbrain ? If not I'd be happy to.

@maschad maschad self-assigned this Apr 24, 2023
maschad referenced this issue in libp2p/js-libp2p-webrtc May 2, 2023
@maschad
test: add transport compliance tests (#132)
6d4bf29
@p-shahi p-shahi linked a pull request May 3, 2023 that will close this issue
test: add transport compliance tests libp2p/js-libp2p-webrtc#149
Closed
@maschad maschad mentioned this issue May 15, 2023
Closed
maschad referenced this issue in libp2p/js-libp2p-webrtc May 16, 2023
@maschad
test: added compliance tests (#132)
79674e6
@maschad maschad assigned achingbrain and unassigned maschad May 16, 2023
@p-shahi
Copy link
Member

p-shahi commented Jun 8, 2023

Blocked on #1852

@p-shahi p-shahi transferred this issue from libp2p/js-libp2p-webrtc Jun 19, 2023
@maschad maschad assigned maschad and unassigned achingbrain Sep 12, 2023
@maschad maschad changed the title Run transport compliance tests libp2p(@webrtc): Add transport compliance tests Sep 12, 2023
@maschad maschad mentioned this issue Sep 15, 2023
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue Sep 21, 2023
@maschad
test: update test setup for webRTC (libp2p#1836)
6022a52
@maschad maschad removed their assignment May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
js-libp2p
Status: 🧊Icebox🥶
Milestone
No milestone
3 participants
@achingbrain @maschad @p-shahi