Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Addresses #35

Open
ghost opened this issue Nov 27, 2017 · 4 comments
Open

Addresses #35

ghost opened this issue Nov 27, 2017 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 27, 2017

/dns4/ws-star-signal-1.servep2p.com/wss/p2p-websocket-star/

Shouldn't this be:

/dns4/ws-star-signal-1.servep2p.com/tcp/443/wss/p2p-websocket-star

With the added /tcp/443 and the trailing slash removed

@mkg20001
Copy link
Member

Internally this is converted to https://ws-star-signal-1.servep2p.com so it doesn't matter. (It needs to be an URL because socket.io)

@ghost
Copy link
Author

ghost commented Nov 27, 2017

Okay, understood -- multiaddrs are always explicit, so we need that /tcp/443 bit there. TCP multiaddrs are always of the form /ip4/<addr>/tcp/<port> (and same for /ip6 of course).

@ghost ghost mentioned this issue Nov 27, 2017
24 tasks
@daviddias
Copy link
Member

Just tested, indeed it fails with an addr with tcp + port

Error: invalid multiaddr: /dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/Qma3uqwymdqwXtC4uvmqqwwMhTDHD7xp9FzM75tQB5qRM3

@daviddias
Copy link
Member

js-mafmt works well with that multiaddr -- multiformats/js-mafmt#20 --, the issue is on the module multiaddr parsing function

@daviddias daviddias added the ready label Feb 5, 2018
mkg20001 added a commit that referenced this issue Jul 21, 2019
feat: async await and upgrades Hapi to v18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants