Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge js-libp2p-{core pieces} into js-libp2p repo #384

Closed
30 tasks done
daviddias opened this issue Jul 20, 2019 · 6 comments · Fixed by #400
Closed
30 tasks done

Merge js-libp2p-{core pieces} into js-libp2p repo #384

daviddias opened this issue Jul 20, 2019 · 6 comments · Fixed by #400

Comments

@daviddias
Copy link
Member

daviddias commented Jul 20, 2019

Following ipfs/js-ipfs#2222, the proposal is to:

Merge into js-libp2p, the following modules:

Cleanup

NPM Deprecation Notice

Readme Deprecation Notice

Github Archival

Description replacement: [DEPRECATED]: now part of the https://github.com/libp2p/js-libp2p repo

@jacobheun
Copy link
Contributor

I put together a Draft PR of this, #388, for just libp2p-switch so we can chat about the approach there.

@jacobheun
Copy link
Contributor

@daviddias each module has been deprecated on npm, and the readme's all include the notice and a link to js-libp2p. I added TODOs to the issue description, #384 (comment), to archive and update the description of each repo. If you could help with that, it would be much appreciated! ❤️

@daviddias
Copy link
Member Author

@jacobheun done! Thank you for making it super simple :)

@vasco-santos
Copy link
Member

vasco-santos commented Jan 15, 2020

Can we close this? Or should we wait on libp2p-keychain PR to be merged?

@jacobheun
Copy link
Contributor

jacobheun commented Jan 17, 2020

Yes! libp2p-keychain can and probably should be a separate effort.

@daviddias
Copy link
Member Author

PR to follow for those interested #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants