-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add js-libp2p-keychain to the libp2p codebase #388 #525
Conversation
Fixes #2
Add syntax highlighting to README
This commit updates all CI scripts to the latest version
Updating CI files
Persist the key info in the store
test: key name comparision
* test: openssl interop is now the responsibility of libp2p-crypto * feat: use libp2p-crypto, not node-forge, for key management * fix: use libp2p-crypto.pbkdf, not node-forge * fix: do not ship CMS This removes all depencies on node-forge * test: update dependencies * test: remove dead code
This reverts commit b6d5313.
c3a1e3c
to
0896371
Compare
@jacobheun |
0896371
to
8caf4ad
Compare
8caf4ad
to
6973449
Compare
@jacobheun just rebased this. We should document how to use |
We should integrate this into the libp2p api, this would likely look like I would expect users to be able to provide a datastore to libp2p and it would just handle key storage. Users should probably also be able to specify a separate datastore for libp2p-keychain. (We should likely always want these to be "separate" datastores so we're not putting dht/peer/etc data in the same place as our keys).
At the bare minimum it needs to be documented in the API and Configuration readme's, and we really need more tests around using this directly with libp2p.
|
This PR adds js-libp2p-switch to js-libp2p as a part of #384 and #509 .
Things to note:
./src/keychain
and its tests under./test/keychain
.Note on Merging:
Right now the plan (obtained from
libp2p-keychain
PR) is to: