Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the panic when SemiDuplex has no outbound stream yet #136

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

Nashatyrev
Copy link
Collaborator

  • Fix CompletableFuture anyComplete() implementation
  • Tolerate the case when trying writing to a peer without established outbound stream within P2PServiceSemiDuplex

Resolves Consensys/teku#2620

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Nashatyrev Nashatyrev merged commit 6489ad6 into develop Aug 31, 2020
@Nashatyrev Nashatyrev mentioned this pull request Sep 1, 2020
Nashatyrev added a commit that referenced this pull request Sep 1, 2020
Release 0.5.6
#136 (Fix the panic when SemiDuplex has no outbound stream yet)
@Nashatyrev Nashatyrev deleted the fix-semi-duplex-no-outbound branch September 8, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARN - AbstractRouter internal error on message control / No active outbound stream to write data control
2 participants