Get negotiated Gossip protocol version from either inbound or outbound stream #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Nov 13, 2020
src/test/kotlin/io/libp2p/pubsub/gossip/GossipPubsubRouterTest.kt
Outdated
Show resolved
Hide resolved
|
Looks this PR was closed accidentally via deleting its branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to PR #136 :
when the outbound Gossip stream is not created yet and remote Gossip peer (just connected) sends GRAFT to which we want respond with PRUNE causes exception (see Consensys/teku#2836).
This is because the
GossipRouter.enqueuePruneneeds the negotiated Gossip version to respond properly (Gossip v1.1 should be backward compatible with v1.0) and the version is retrieved from outbound stream. As the outbound stream can be not created yet the version can be retrieved from the inbound stream with the same result. One of inbound or outbound stream should 100% existFixes Teku issue Consensys/teku#2836 when new version integrated