-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate both Gradle projects into one #198
Consolidate both Gradle projects into one #198
Conversation
Ugh. I messed up the rebase because I forgot the main branch was called |
Combine the "example" projects into the main project. I needed to move the main library into it's own module so the other libraries could exist. This allows a developer to open this project in IntelliJ and build all of the projects easily. There's still more clean-up to do such as consolidating the Kotlin versions to one top level declaration, but I'm trying to make the minimal amount of changes to get this to work. Closes #153 Closes #152
Hey @Nashatyrev and @ajsutton, do y'all mind giving this a 👀 when you get the chance? If it's not something y'all want, please let me know that too, and I'll close the PR. |
Hey @SalvatoreT Sorry for such long ignorance! I think this is generally a good refactoring Though, I tried to build on my box and got the following error:
Is it an option to skip |
If you comment out that project from the diff --git a/settings.gradle b/settings.gradle
index 178bb1e..b1227c7 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -2,6 +2,6 @@ include ':jvm-libp2p-minimal'
include ':examples:pinger'
include ':examples:chatter'
include ':examples:cli-chatter'
-include ':examples:android-chatter'
+// include ':examples:android-chatter'
rootProject.name = 'jvm-libp2p-minimal' I'm not sure off the top of my head of another clean solution. |
Tried to comment his line but the build still fails for another reason |
What was the other reason it failed? How do you run the examples in this project today? |
Combine the "example" projects into the main project. I needed to move
the main library into it's own module so the other libraries could
exist. This allows a developer to open this project in IntelliJ and
build all of the projects easily.
There's still more clean-up to do such as consolidating the Kotlin
versions to one top level declaration, but I'm trying to make the
minimal amount of changes to get this to work.
Closes #153
Closes #152