Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to multi-module project #267

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

Nashatyrev
Copy link
Collaborator

@Nashatyrev Nashatyrev commented Feb 17, 2023

The aim is to make this project multi-module to later add the gossip simulator module which now lives in tests in a separate branch.

  • extract the main module as a libp2p submodule
  • move specific dependencies and gradle plugins to the libp2p module
  • remove unused dependencies
  • add examples as submodules and adjust their code
  • android example is still out of the scope as I couldn't make it working in a reasonable time. Need to file an issue on this.
  • modules which want their artifacts to be published should define mavenArtifactId project property. Now just libp2p module is published under the old artifact id jvm-libp2p-minimal
  • remove 'log4j-core' from 'libp2p' module: it's needed in runtime for tests or applications only
  • extract dependency versions to the dedicated file

This PR was inspired by #198, thanks to @SalvatoreT

@Nashatyrev Nashatyrev marked this pull request as ready for review February 17, 2023 10:33
@Nashatyrev
Copy link
Collaborator Author

@StefanBratanov had approved this PR

@Nashatyrev Nashatyrev merged commit 89ba1c2 into libp2p:develop Feb 17, 2023
@Nashatyrev Nashatyrev deleted the refactor/multi-module branch May 17, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant