rust-client: handle address parsing error gracefully #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multiaddress sent to us from the remote may contain a Protocol that is not yet implemented in rust-multiaddr. This causes the parsing from `Vec` to `Multiaddr` to fail. Rather than treating this as an error, this commit changes the implementation to simply skip the address in this case.
thomaseizinger
approved these changes
Dec 12, 2022
mxinden
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Good to merge from my end, though one suggestion.
What do you think of adding a debug! in case of failure. Might make future debugging easier, in case there ever is an address that we should be able to parse, but can't.
In general, I would like the Rust multiaddr implementation to strive for supporting all common libp2p protocols. Thus this fix should only be required int he short term.
Good idea. Done in 5ad4f38. |
|
Can we push out a point release for this? |
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiaddress of a remote peer may contain a Protocol that is not yet implemented in
rust-multiaddr.This causes the parsing from
VectoMultiaddrto fail. Right now this results in an error that aborts the whole program.This PR changes the implementation to simply skip an address that we can not parse.
Reported in #62 (comment).