Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement prepare_uninitialized_buffer and read_buf in our AsyncRead implementations #1080

Closed
tomaka opened this issue Apr 22, 2019 · 1 comment · Fixed by #1107
Closed

Implement prepare_uninitialized_buffer and read_buf in our AsyncRead implementations #1080

tomaka opened this issue Apr 22, 2019 · 1 comment · Fixed by #1107
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Apr 22, 2019

For optimisation purposes. Quite a lot of CPU seems to be wasted in superfluous memsets.
@tomaka tomaka added difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Apr 22, 2019
@tomaka
Copy link
Member Author

tomaka commented Apr 28, 2019

7% of the CPU usage of Substrate consists in zeroing buffers we are reading networking messages to.

@tomaka tomaka added the priority:important The changes needed are critical for libp2p, or are blocking another project label Apr 28, 2019
tomaka added a commit to tomaka/libp2p-rs that referenced this issue May 7, 2019
@tomaka
Fix libp2p#1080
f1d389b
tomaka added a commit to tomaka/libp2p-rs that referenced this issue May 7, 2019
@tomaka
Fix libp2p#1080
cdb6916
@tomaka tomaka mentioned this issue May 7, 2019
Merged
tomaka added a commit that referenced this issue May 10, 2019
@tomaka
Add implementations of prepare_uninitialized_buffer and read_buf wher…
c2398ad 
…e relevant (#1107)

* Fix #1080

* Fix browser WebSockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add implementations of prepare_uninitialized_buffer and read_buf where relevant tomaka/libp2p-rs
1 participant
@tomaka