Add implementations of prepare_uninitialized_buffer and read_buf where relevant #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
tomaka
commented
May 7, 2019
| @@ -80,6 +80,10 @@ where | |||
| fn destroy_outbound(&self, _: Self::OutboundSubstream) { | |||
| } | |||
|
|
|||
| unsafe fn prepare_uninitialized_buffer(&self, _: &mut [u8]) -> bool { | |||
| false | |||
There was a problem hiding this comment.
@twittner Please confirm that yamux doesn't fetch data from the buffer when you call read (I would be surprised if it did, but you never know).
There was a problem hiding this comment.
As far as I can tell, it doesn't.
romanb
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1080
Most of the CPU usage is in
memcpy(EDIT: andmemset), so this should hopefully give a speed boost to the library.Also adds
prepare_uninitialized_bufferto theStreamMuxertrait.