Fix identify not compiling for wasm #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twittner
approved these changes
Nov 29, 2019
| @@ -24,6 +23,7 @@ wasm-timer = "0.2" | |||
| unsigned-varint = { version = "0.2.3", features = ["futures-codec"] } | |||
|
|
|||
| [dev-dependencies] | |||
| async-std = "1.0" | |||
There was a problem hiding this comment.
We should probably import async-std everywhere as 1 instead of 1.x. According to their stability policy, changes in minor and patch versions are backwards compatible.
There was a problem hiding this comment.
async-std = "1" and async-std = "1.0" should do exactly the same thing. Cargo will pull async-std 1.1 even if we say 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM CI build should be green again now.